Skip to content

Use FeatureTest.isCanvasFilterSupported in _bakeSMaskCanvas#21264

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:simplify_no_filter
May 12, 2026
Merged

Use FeatureTest.isCanvasFilterSupported in _bakeSMaskCanvas#21264
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:simplify_no_filter

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented May 12, 2026

No description provided.

@calixteman calixteman requested a review from timvandermeij May 12, 2026 18:02
@calixteman
Copy link
Copy Markdown
Contributor Author

calixteman commented May 12, 2026

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented May 12, 2026

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2e45e42ac9d80d1/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented May 12, 2026

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fde3ce8195dec5a/output.txt

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.17%. Comparing base (0c66063) to head (1dac67f).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/display/canvas.js 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21264   +/-   ##
=======================================
  Coverage   56.17%   56.17%           
=======================================
  Files         220      220           
  Lines       59234    59233    -1     
=======================================
+ Hits        33273    33275    +2     
+ Misses      25961    25958    -3
Flag Coverage Δ
fonttest 8.64% <ø> (ø)
unittest 55.45% <0.00%> (+<0.01%) ⬆️
unittestcli 54.70% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented May 12, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2e45e42ac9d80d1/output.txt

Total script time: 18.78 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/2e45e42ac9d80d1/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented May 12, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fde3ce8195dec5a/output.txt

Total script time: 24.54 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/fde3ce8195dec5a/reftest-analyzer.html#web=eq.log

timvandermeij
timvandermeij approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thanks!

@timvandermeij timvandermeij merged commit 10abe66 into mozilla:master May 12, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

core smask

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calixteman @moz-tools-bot @codecov-commenter @timvandermeij